fix (bbb-web): Null pointer exception when parent meeting does not exist #18986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up from #18975 |
bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy
Outdated
Show resolved
Hide resolved
bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy
Outdated
Show resolved
Hide resolved
gustavotrott
requested changes
Oct 20, 2023
…/controllers/ApiController.groovy Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
…/controllers/ApiController.groovy Co-authored-by: Gustavo Trott <gustavo@trott.com.br>
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
Automated tests Summary🚨 Test workflow has failedClick here to check the action test reports |
gustavotrott
approved these changes
Oct 20, 2023
gustavotrott
changed the title
gustavotrott
merged commit 730803c
into
bigbluebutton:v2.7.x-release
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Performs a check when creating a breakout room through the API to see if the parent meeting exists.
Motivation
Currently no check is done to see if the meeting corresponding to the provided
parentMeetingIDactually exists which can lead to an error.