fix (graphql-middleware): User get Presenter status but can't stop external video #19550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts ☹ |
|
Automated tests Summary✅ All the CI tests have passed! |
|
hey @ramonlsouza , can you confirm wether the bug is gone? |
|
closes #19545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the latest development call, as highlighted by @antobinary, an issue was identified in the system. When a user is granted presenter status, they encounter a problem where they are unable to stop external video playback, among other presenter-specific functionalities.
This Pull Request (PR) addresses and resolves this issue. The root cause of the problem was identified as follows: when a user becomes a presenter, the client-side application ceases various data subscriptions. This led to an issue where, if the Hasura backend responded with data related to these subscriptions, the client's middleware no longer recognized or handled this data, as the subscriptions had been stopped. The PR contains fixes to ensure that this problem does not occur when a user is assigned presenter status.