Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (graphql-middleware): User get Presenter status but can't stop external video #19550

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix (graphql-middleware): User get Presenter status but can't stop external video #19550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f92f9
Fix a bug when user get Presenter
gustavotrott Jan 31, 2024
a5776c4
resolve conflicts
gustavotrott Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bbb-graphql-middleware/internal/hascli/conn/reader/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func HasuraConnectionReader(hc *common.HasuraConnection, fromHasuraToBrowserChan
hc.Browserconn.ActiveSubscriptionsMutex.RUnlock()
if !ok {
log.Debugf("Subscription with Id %s doesn't exist anymore, skiping response.", queryId)
return
continue
}

//When Hasura send msg type "complete", this query is finished
Expand Down
2 changes: 1 addition & 1 deletion bbb-graphql-middleware/internal/websrv/connhandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func InvalidateSessionTokenConnections(sessionTokenToInvalidate string) {
close(browserConnection.HasuraConnection.MsgReceivingActiveChan)

// Wait until there are no active mutations
for iterationCount := 0; iterationCount < 100; iterationCount++ {
for iterationCount := 0; iterationCount < 20; iterationCount++ {
activeMutationFound := false
browserConnection.ActiveSubscriptionsMutex.RLock()
for _, subscription := range browserConnection.ActiveSubscriptions {
Expand Down