Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent from exposing client private configs through Graphql #19649

Conversation

gustavotrott
Copy link
Collaborator

The settings.yml file includes sensitive configurations under the :private property. It is crucial that this information is not exposed to users via GraphQL. Additionally, there is no need for Akka applications to load these settings. Therefore, the purpose of this PR is to prevent Akka applications from reading these sensitive settings to enhance security measures.

image

@gustavotrott gustavotrott added this to the Release 3.0 milestone Feb 20, 2024
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gustavotrott gustavotrott changed the title Prevent from expose client private configs through Graphql Prevent from exposing client private configs through Graphql Feb 20, 2024
Copy link

Automated tests Summary

All the CI tests have passed!

Copy link
Collaborator

@GuiLeme GuiLeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gustavotrott gustavotrott merged commit 6dad569 into bigbluebutton:v3.0.x-release Feb 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants