fix(plugin): Fix generic component and add ui-data for current layout #19710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and add ui-data current_layout
This was referenced Feb 29, 2024
…k-fix-generic-component-add-event
|
This pull request has conflicts ☹ |
|
Automated tests Summary✅ All the CI tests have passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It basically fixes some stuff in the generic component logic as well as refactors some parts. Moreover, it adds a new ui-data: the current-layout, it is really useful when we have a generic component, to which content is in the presentation area at that point.
Motivation
This PR helps a lot the development of the new official plugin: generic link (I'll link it here when the PR for that is ready)
More
Closely related to bigbluebutton/bigbluebutton-html-plugin-sdk#74