Graphqh: Automatically set running=false when timer has counted down to 0 #19714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted by @Scroody, the issue at hand is that
Timer.running
remains set totrue
indefinitely, even after the timer has counted down to 0. The proposed change in this PR is to adjust the timer's behavior so that running becomesfalse
once the timer reaches its conclusion.Additionally, the PR includes a refactoring of column names: changing
startedAt
tostartedOn
andendedAt
toendedOn
. This alteration aims to standardize naming conventions within the database, whereOn
is used for bigint values andAt
indicates PostgreSQL timestamps.