Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphqh: Automatically set running=false when timer has counted down to 0 #19714

Conversation

gustavotrott
Copy link
Collaborator

As highlighted by @Scroody, the issue at hand is that Timer.running remains set to true indefinitely, even after the timer has counted down to 0. The proposed change in this PR is to adjust the timer's behavior so that running becomes false once the timer reaches its conclusion.

Additionally, the PR includes a refactoring of column names: changing startedAt to startedOn and endedAt to endedOn. This alteration aims to standardize naming conventions within the database, where On is used for bigint values and At indicates PostgreSQL timestamps.

@gustavotrott gustavotrott added this to the Release 3.0 milestone Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

Automated tests Summary

All the CI tests have passed!

Copy link
Collaborator

@Scroody Scroody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just finished testing and looks like it's working fine. Great job.

@gustavotrott gustavotrott merged commit 4d71f63 into bigbluebutton:v3.0.x-release Feb 29, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants