Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whiteboard): Remove Conditionally Called Hooks Error #19831

Closed

Conversation

KDSBrowne
Copy link
Collaborator

What does this PR do?

This PR resolves an issue where some hooks were called conditionally, which is not permitted by Reacts rules of hooks. By ensuring that all hooks are called unconditionally at the top level of functional components, we maintain the correct execution order of hooks ensuring consistency across renders.

Motivation

image

@antobinary antobinary added this to the Release 3.0 milestone Mar 18, 2024
Copy link
Member

@ramonlsouza ramonlsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client does not load when v3.0.x-release branch is merged to this PR

2024-03-27_09-47

@KDSBrowne KDSBrowne force-pushed the v3-sonarcloud-err branch 3 times, most recently from 79ee06d to 8d3bf51 Compare March 27, 2024 16:50
@KDSBrowne KDSBrowne closed this Mar 27, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants