Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whiteboard): Remove Conditionally Called Hooks Error #19915

Merged

Conversation

KDSBrowne
Copy link
Collaborator

What does this PR do?

This PR resolves an issue where some hooks were called conditionally, which is not permitted by Reacts rules of hooks. By ensuring that all hooks are called unconditionally at the top level of functional components, we maintain the correct execution order of hooks ensuring consistency across renders.

same changes in #19831

Motivation

image

@antobinary antobinary added this to the Release 3.0 milestone Mar 27, 2024
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

github-actions bot commented Apr 4, 2024

Automated tests Summary

All the CI tests have passed!

@antobinary antobinary merged commit 7838a64 into bigbluebutton:v3.0.x-release Apr 5, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants