Notification of legacy browse #7303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the |
antobinary
approved these changes
Apr 29, 2019
This was referenced May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR is here, #7295.
There was an issue where adding the
meteorblock to package.json caused the client/compatibility directory to no longer be included. We use that directory to hold our old JS files that don't have module support and can't be imported. The additional commit moves the JS files to the public directory and adds them to the main HTML page. The legacy browser still tries to load those files and they sometimes throw exceptions, but it's not a functional issue.One additional thing that is now required is that the five JS files have no cache busting so I added
?v=VERSIONvalues so that we can substitute in the client version to bust the cache like we do in the Flash client.