Improve client reconnection #7583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 3, 2019 11:15
|
We are still able to toggle recording on/off while offline For the chat -- GitHub seems to prefer being able to type but when you hit send it shows "You cannot send at this time" or something like it. What is your opinion on the value of each approach? |
|
Actually it seems you blocked the possibility to click Yes in the recording toggle modal. That should work too. I anticipated that the control itself would appear disabled (so no modal even). Screenshare seems to still need a disable state change:
|
added 6 commits
June 21, 2019 16:51
antobinary
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the client when server is down, in order to avoid inconsistent states when reconnect:
Retry nowoption when users are disconnected.makeCallwhile disconnected.Exit from audio and disableJoin audiobutton.Prevent "lingering" users.Exit from video.Edit
After a call with @antobinary we decide that the users will not be removed from audio and video.
This PR close #3811.