Fix regression from #7606 #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a new property mysteriously being checked for in #7606 when trying to add a new User. The new property was "moderator" which doesn't exist in the User data model in any other components. Adding this check broke a few other message handlers because they use the proper data model and didn't conform to the changes made in #7606. I rolled back the check and did proper data fetching to only user properties that should exist.
While doing this I discovered that any exceptions thrown during redis message handling were being caught and silenced so we had no way of detecting this regression until we noticed that functionality was broken. I changed the exception handling to always log as an error so we can detect these regressions much easier in the future.
Fixes #7697