Add ping-pong message to html5 client #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiebel
approved these changes
Jul 1, 2019
capilkey
reviewed
Jul 2, 2019
antobinary
approved these changes
Jul 4, 2019
antobinary
added a commit
to antobinary/bigbluebutton
that referenced
this pull request
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intend to add the ping-pong feature to BBB html5 to avoid users stay in meeting when it's disconnected.
Steps to test:
I use an internal Meteor API that allows just trigger a changed event without a collection actually changing.
That was triggered via the setIterval setted in publisher.
I made two
setIntervals:5 seconds is used to create a pong routine to server and notify user to send a ping.
10 seconds is used to run the clear inactive users routine that clean all incative users in the last 10 seconds.