Fix nav bar performance issue #7967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiebel
reviewed
Aug 21, 2019
| @@ -1,17 +1,17 @@ | |||
| import React, { PureComponent } from 'react'; | |||
| import React, { } from 'react'; | |||
There was a problem hiding this comment.
Just out of curiosity, why sometimes you use named import and sometimes you use React.?
jfsiebel
reviewed
Aug 21, 2019
|
|
||
| const PUBLIC_CONFIG = Meteor.settings.public; | ||
|
|
||
| const ROLE_MODERATOR = Meteor.settings.public.user.role_moderator; |
There was a problem hiding this comment.
PUBLIC_CONFIG.user.role_moderator maybe?
capilkey
reviewed
Aug 23, 2019
bigbluebutton-html5/imports/ui/components/nav-bar/recording-indicator/component.jsx
Outdated
Show resolved
Hide resolved
…dicator/component.jsx Co-Authored-By: Chad Pilkey <capilkey@gmail.com>
…404/bigbluebutton into nav-bar-performance-issue
|
We don't clear |
|
When you use this configuration
The record icon don't appear
|
capilkey
reviewed
Aug 27, 2019
bigbluebutton-html5/imports/ui/components/nav-bar/recording-indicator/component.jsx
Outdated
Show resolved
Hide resolved
capilkey
reviewed
Aug 27, 2019
bigbluebutton-html5/imports/ui/components/nav-bar/recording-indicator/component.jsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inted to fix performance issues in nav bar and move the recordProp field from the meeting collection to own collection in mongoDB.
To test it I advice to use the npm package why did you update this package list all updates and it causes.