Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join by phone icon placement in RTL #7996

Merged
merged 2 commits into from Aug 30, 2019

Conversation

KDSBrowne
Copy link
Collaborator

Closes #7994

} = this.props;

const showMicrophone = forceListenOnlyAttendee || audioLocked;

const dialAudioLabel = isRTL
? `🡸 ${intl.formatMessage(intlMessages.audioDialTitle)}`
: `${intl.formatMessage(intlMessages.audioDialTitle)} 🡺`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the same arrow icon as before. Is this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional, wasn't able to find the opposite arrow to the one previously implemented by @BobakOftadeh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antobinary Unicode arrows can be found here https://www.compart.com/en/unicode/search?q=Arrow#characters
There is no leftwards arrow for the previously selected one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's always CSS rotation. Let me pull the code and see if it's too wide/bold at the moment

Copy link
Member

@antobinary antobinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2019-08-28 14-54-05
I would expect in RTL languages the <- to be in the leftmost part of the row. @GhaziTriki please clarify

LTR: blah blah blah ->
RTL: <- halb halb halb

And what I see now is
RTL: halb halb halb <-

@antobinary antobinary merged commit 2cbe91e into bigbluebutton:master Aug 30, 2019
@KDSBrowne KDSBrowne deleted the issue-7994 branch September 3, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join by phone icone in RTL must be before the text and in the other direction
3 participants