New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix join by phone icon placement in RTL #7996
Conversation
} = this.props; | ||
|
||
const showMicrophone = forceListenOnlyAttendee || audioLocked; | ||
|
||
const dialAudioLabel = isRTL | ||
? `🡸 ${intl.formatMessage(intlMessages.audioDialTitle)}` | ||
: `${intl.formatMessage(intlMessages.audioDialTitle)} 🡺`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the same arrow icon as before. Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was intentional, wasn't able to find the opposite arrow to the one previously implemented by @BobakOftadeh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antobinary Unicode arrows can be found here https://www.compart.com/en/unicode/search?q=Arrow#characters
There is no leftwards arrow for the previously selected one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's always CSS rotation. Let me pull the code and see if it's too wide/bold at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect in RTL languages the <- to be in the leftmost part of the row. @GhaziTriki please clarify
LTR: blah blah blah ->
RTL: <- halb halb halb
And what I see now is
RTL: halb halb halb <-
Closes #7994