New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple external videos synced to different meetings #8232
Fix multiple external videos synced to different meetings #8232
Conversation
The Streamer on the server side is the only part I'm still not sold on also. It seems like the way it's supposed to be used is to create a Streamer and they never get removed so I'm not sure how that will work with servers that have been up for weeks. When I load a second client to the meeting there's an error put out to the console:
It seems like there's some sort of storage inside the Streamer code. |
That seems to be an error in my code though, gonna look into it |
It could be worked around so it only tries to create once, but that's not the part I'm actually worried about. It's the fact that there's a record inside the Streamer code that saves all of the created objects. I don't see any destruction built into it. |
I'll perform some tests on the library to find out if the objects accumulate on the server without destruction. |
I read the streamer code, as far as I understand as long as the clients remove the listeners (we do this in the component and service code) we can safely delete the reference to the streamer objects. |
Checking with StreamerCentral collection seems to solve the issue if that's the only place it stores them. That was my one worry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The meetings are isolated and the Streamers are getting destroyed.
By creating a different server instance of the streamer once for every meeting. Still trying to determine if the streamers are collected automatically when the objetcts are collected or if I should do something to clear them when the meeting ends.