Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable SMTPS: SMTP over direct TLS connection #2485

Merged
merged 9 commits into from Mar 1, 2021
Merged

enable SMTPS: SMTP over direct TLS connection #2485

merged 9 commits into from Mar 1, 2021

Conversation

zimmersi
Copy link
Contributor

  • enable SMTPS for ActionMailer, to be able to send mails over direct TLS connections, usually port 465

@coveralls
Copy link

coveralls commented Jan 27, 2021 •
edited

Coverage Status

Coverage decreased (-0.03%) to 90.815% when pulling 5f34bf6 on diekinderwelt:enable-smtps into 6ee92c8 on bigbluebutton:master.

@zimmersi
Copy link
Contributor Author

seems that there are several issues connected, that get closed but not solved!

#2363
#1881
#1195

mabras
mabras reviewed Jan 27, 2021
View reviewed changes
Gemfile Outdated
@@ -86,6 +86,7 @@ gem 'pluck_to_hash', '~> 1.0.2'
gem 'local_time', '~> 2.1.0'

group :production do
gem 'sqlite3', '~> 1.3.6'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

@farhatahmad
Copy link
Collaborator

Can you rebase to master and then run bundle exec rubocop -A before pushing?

@zimmersi
Copy link
Contributor Author

hi @farhatahmad,

I get
invalid option: -A

do you mean
-a, --auto-correct Auto-correct offenses.
?

@farhatahmad farhatahmad merged commit ba0ec6b into bigbluebutton:master Mar 1, 2021
@zimmersi zimmersi deleted the enable-smtps branch April 8, 2021 13:55
galupa pushed a commit to galupa/greenlight that referenced this pull request Jun 29, 2021
@zimmersi
enable SMTPS: SMTP over direct TLS connection (bigbluebutton#2485)
d937c70 
* enable SMTPS: SMTP over direct TLS connection

* remove gem 'sqlite3', '~> 1.3.6' as requested

* enable SMTPS: SMTP over direct TLS connection

* remove gem 'sqlite3', '~> 1.3.6' as requested

* changed image name to kwgl

* rebase and rubocop -a

* removed  gem 'sqlite3', '~> 1.3.6'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabras mabras mabras left review comments

@farhatahmad farhatahmad farhatahmad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimmersi @coveralls @farhatahmad @mabras