Merge pull request #2157 from muawiakh/fix-arg-parse

Problem: argument not parsed properly while generating configs
bigchaindb · Mar 27, 2018 · 3cf921b · 3cf921b
2 parents 3f2d40f + a047838
commit 3cf921b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/k8s/scripts/functions b/k8s/scripts/functions
@@ -218,16 +218,16 @@ function generate_config_map(){
     bdb_instance_name="$BDB_CN-$INDEX"
     ngx_instance_name="ngx-instance-$INDEX"
 
-    bdb_user=`cat $1/"$BDB_CN"-"${INDEX}".user`
-    mdb_admin_username=$2
-    node_fqdn=$3
-    tm_seeds=$4
-    tm_validators=$5
-    tm_validators_power=$6
-    tm_genesis_time=$7
-    tm_chain_id=$8
-    tm_instance_name=$9
-    dns_resolver_k8s=$10
+    bdb_user=`cat "${1}"/"$BDB_CN"-"${INDEX}".user`
+    mdb_admin_username="${2}"
+    node_fqdn="${3}"
+    tm_seeds="${4}"
+    tm_validators="${5}"
+    tm_validators_power="${6}"
+    tm_genesis_time="${7}"
+    tm_chain_id="${8}"
+    tm_instance_name="${9}"
+    dns_resolver_k8s="${10}"
 
     cat > config-map.yaml << EOF
 apiVersion: v1

diff --git a/k8s/scripts/generate_configs.sh b/k8s/scripts/generate_configs.sh
@@ -87,4 +87,4 @@ convert_b64 $BASE_K8S_DIR $BASE_CA_DIR/$BASE_EASY_RSA_PATH $BASE_CLIENT_CERT_DIR
 get_users $BASE_USERS_DIR $BASE_CA_DIR/$BASE_EASY_RSA_PATH
 generate_secretes_no_threescale $BASE_K8S_DIR $SECRET_TOKEN $HTTPS_CERT_KEY_FILE_NAME $HTTPS_CERT_CHAIN_FILE_NAME $MDB_ADMIN_PASSWORD
 
-generate_config_map $BASE_USERS_DIR $MDB_ADMIN_USER $NODE_FQDN $TM_SEEDS $TM_VALIDATORS $TM_VALIDATOR_POWERS $TM_GENESIS_TIME $TM_CHAIN_ID $TM_INSTANCE_NAME
+generate_config_map $BASE_USERS_DIR $MDB_ADMIN_USER $NODE_FQDN $TM_SEEDS $TM_VALIDATORS $TM_VALIDATOR_POWERS $TM_GENESIS_TIME $TM_CHAIN_ID $TM_INSTANCE_NAME $NODE_DNS_SERVER