Improve core functionality

[r-marques]

Abstract

Implement core functionality from whitepaper.

Goals

This issue is meant to be a todo of all the issues related to core functionality that needs to be implemented for the core algorithm to match the description in the whitepaper and also tasks that to not add any features and are sometimes pushed back but that increase the robustness and are required for a quality production ready product.

Steps

General

• What to do if a tx gets copied from an undecided or decided_valid block to the backlog? - What to do if a tx gets copied from an undecided or decided_valid block to the backlog? #220 (unassigned)
• Set RethinkDB read mode to 'majority' to improve consistency - Proposal: set RethinkDB read mode to 'majority' to improve consistency #158 (ryan)
• Validate transaction before writing it to the backlog Validate transaction before writing it to the backlog #109 (closed, won't do)
• Set durability == hard for all writes Ensure durability == 'hard' everywhere #504
• Transfer tx validation must check to ensure all referenced outputs are in valid blocks - Transfer tx validation must check to ensure all referenced outputs are in valid blocks #526
• Ensure no same-asset transactions get put in the same block - Ensure no same-asset transactions get put in the same block #527 (ryan)
• Double spend shouldn't be included in a block - Double spend shouldn't be included in a block (block voted invalid) #592
• Rewriting transactions from invalid block may lead to DoubleSpends - Rewriting transactions from invalid block may lead to DoubleSpends #774

Voting

• Skip/abort voting on a block if/when it is already decided: Skip/abort voting on a block if/when it is already decided #190
• Handling the case of votes pointing to different blocks as the previous block: Handling the case of votes pointing to different blocks as the previous block #165 (ryan), PR check votes agree on previous block #565

Algorithmic/WP

• Transactions from invalid block should be put back in the backlog - Transactions from an invalid block should be put back into the backlog #193 (ryan), PR add election class, process starts #221

Querying

• All backend implementations of get_transactions_by_asset_id() should ignore invalid blocks: All backend implementations of get_transactions_by_asset_id() should ignore invalid blocks #332
• All backend implementations of get_transactions_by_metadata_id() should ignore invalid blocks: All backend implementations of get_transactions_by_metadata_id() should ignore invalid blocks #792
• Queries to the bigchain table should ignore invalid blocks - issue Queries to the bigchain table should ignore invalid blocks #192 (ryan), PR Ignore invalid blocks #324

Mutability

The wire protocol firewall (#594) will prevent deletes & updates on the bigchain & votes tables. If a node deletes a transaction from the backlog table, then the client can just resend it, so such deletions don't have to be reverted. As for updates to the backlog table, those must be allowed, for example, to reassign stale transactions (PR #359).

• Voting as separate table: Voting as separate table #368 (ryan)
• Prevent deletes on the bigchain table - Prevent deletes on the bigchain table #197 (ryan), PR Core/197/revert bigchain deletes #330
• Handle deletes on the backlog table - Handle deletes on the backlog table #196 (ryan), PR Core/196/handle backlog deletes #337
• Handle updates on the bigchain table - Handle updates on the bigchain table #195 (unassigned)
• Prevent updates on the backlog table - Prevent updates on the backlog table #194 (unassigned)
• What to do when a node creates another Genesis block? What to do when a node creates another Genesis block? #444 (unassigned) (Moved to meta-issue All known fault vectors accounted for, w/ system test per fault #284)
• When validating a transaction, check to ensure it isn't a duplicate - When validating a transaction, check to ensure it isn't a duplicate #131 (ryan)

Multiprocessing

There were other issues listed here before but then we realized this isn't core consensus stuff.

• Transactions can be orphaned - Transactions can be orphaned #323 (unassigned)
• Handle stale transactions on the backlog table - Handle stale transactions on the backlog table #198 (ryan), PR Core/198/handle stale transactions #359

[ttmc]

I'm going to close this "meta-issue" because there's only one remaining open issue within it ( #444 ); I will just move that issue into meta-issue #284