Core/196/handle backlog deletes #337
Conversation
Current coverage is 91.08%@@ master #337 diff @@
==========================================
Files 18 18
Lines 1285 1357 +72
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1155 1236 +81
+ Misses 130 121 -9
Partials 0 0
|
|
|
||
| if validity and list(validity.values()).count(Bigchain.BLOCK_VALID) == 1: | ||
| # tx made it into a block, and can safely be deleted | ||
| self.q_tx_delete.put(tx['id']) |
There was a problem hiding this comment.
why do we need to store the transactions here?
There was a problem hiding this comment.
As opposed to just the txid? No I don't think so, I will make the changes.
There was a problem hiding this comment.
It was more what do we do with q_tx_delete?
There was a problem hiding this comment.
It's there because BacklogDeleteRevert is a derived class of block, so I didn't have to rewrite the validate_transactions. It expects a queue to take invalid transactions, but yes it's functionally useless.
There was a problem hiding this comment.
It should not be a problem. You never start the delete_transactions process
There was a problem hiding this comment.
Yikes, my mistake...but couldn't the queue fill up and start throwing exceptions?
|
Should I close this? Will backlog also be append only? |
|
This is not that simple because the backlog is used as a temporary storage for unprocessed transactions |
|
Stale PR, closing it. |
Ready for review. Resolves #196.