Ignore invalid blocks #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break | ||
|
|
||
| # Query the transaction in the target block and return | ||
| response = r.table('bigchain').filter(lambda block: block['id'] == target_block_id).nth(0)\ |
There was a problem hiding this comment.
can we use just get? The id is the primary index, so it's fast and the code is more compact. Also, we can get rid of the nth(0) operator.
There was a problem hiding this comment.
What? No! If anything I need to chain more methods on there. jk, i have no idea what I was thinking with that one.
|
|
||
| # vote the block invalid | ||
| vote = b.vote(block, b.get_last_voted_block()['id'], False) | ||
| b.write_vote(block, vote, 2) |
There was a problem hiding this comment.
should the block_number be 3 instead of 2? Should work anyway in the context of the test.
Same here:
https://github.com/bigchaindb/bigchaindb/pull/324/files#diff-5dbcdadd05006f510ee75ac7dae5db47R1083
This was referenced May 25, 2016
ttmc
added a commit
that referenced
this pull request
May 25, 2016
sbellem
pushed a commit
to sbellem/bigchaindb
that referenced
this pull request
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #192 except for checking blocks on
get_tx_by_payload_hash, because no tests exist for this query and I understand we're going to change it soon anyway.May also duplicate #320.
All queries now have one extra query for block validity. I haven't found a more compact/elegant way to do it.