-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove tx from backlog after
written in bigchain
#568
Comments
Whoever makes this change should also make sure that the node assigned to the transaction deletes it from the backlog if it's invalid. |
Ok, I have a plan for this. I have a pending PR to reassign transactions that have been "stale" for too long #359. One feature of my approach is to add a second timestamp at the time of assignment for internal bookkeeping. That way, a separate process can periodically check that no transaction is getting too old. If a transaction has been assigned for too long--e.g. a node has gone down--it gets reassigned. We can use this functionality, and delete transactions after they are added to bigchain. As @ttmc points out, we need to watch for:
I'll start working on a PR with the basic idea. |
My philosophy about transactions going missing (for whatever reason) is that it's up to the client to check on their transactions and if it seems a transaction got lost, then it's up to the client to resend it. |
see @ttmc comment in #555
cc @r-marques @rhsimplex @sbellem @TimDaub @sohkai
The
bigchaindb.get_status(txid)
yields someNone
values over the lifetime of a transactionThis is probably due to the fact that the tx is temporarily in-memory. Can be easily resolved by removing tx from
backlog
after being written tobigchain
and not beforeThe text was updated successfully, but these errors were encountered: