Fix use of locales for python et al #1011
Conversation
Current coverage is 95.97% (diff: 100%)@@ master #1011 diff @@
==========================================
Files 35 35
Lines 1789 1789
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1717 1717
Misses 72 72
Partials 0 0
|
| RUN apt-get update | ||
| # From http://stackoverflow.com/a/38553499 | ||
|
|
||
| RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y locales |
There was a problem hiding this comment.
@josephwinston Why did you do apt-get update and DEBIAN_FRONTEND=noninteractive apt-get install -y locales in the same line? It's not "wrong," I'm just curious if there's some reason that I don't grok.
There was a problem hiding this comment.
Each command in the Dockerfile generates a new image. I grouped those commands together as one so that a single image is produced if the command succeed. This follows the general pattern found at https://docs.docker.com/engine/reference/builder/
There was a problem hiding this comment.
Ah, that makes sense. Thanks for explaining!
@sbellem is our local Docker expert and he's away on holidays for a little while longer, so don't worry if he doesn't review this PR right away.
|
This seems to be a problem in python-rapidjson python-rapidjson/python-rapidjson#52 |
See #1010