transaction.outputs.amount as string #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
==========================================
- Coverage 98.37% 98.34% -0.04%
==========================================
Files 56 56
Lines 2588 2595 +7
==========================================
+ Hits 2546 2552 +6
- Misses 42 43 +1 |
r-marques
reviewed
Mar 15, 2017
bigchaindb/common/transaction.py
Outdated
| @@ -229,6 +229,8 @@ def __init__(self, fulfillment, public_keys=None, amount=1): | |||
| raise TypeError('`amount` must be an int') | |||
| if amount < 1: | |||
| raise AmountError('`amount` must be greater than 0') | |||
| if amount > 9 * 10 ** 18: | |||
There was a problem hiding this comment.
Can we make this a const somewhere so that we don't need to recalculate this value everytime?
r-marques
reviewed
Mar 15, 2017
| validate_raises(tx) | ||
| del tx['asset']['data'] | ||
| tx['asset']['id'] = 'b' * 63 | ||
| validate_raises(tx) |
There was a problem hiding this comment.
Can the asset have no data field?
Is this raising because asset has no data field or because it has a malformed hash?
There was a problem hiding this comment.
Transfers don't have asset.data.
r-marques
approved these changes
Mar 15, 2017
r-marques
reviewed
Mar 15, 2017
bigchaindb/common/transaction.py
Outdated
| if amount > 9 * 10 ** 18: | ||
| raise AmountError('`amount` must be <= 9000000000000000000') | ||
| if amount > self.MAX_AMOUNT: | ||
| raise AmountError('`amount` must be <= %s' % self.MAX_AMOUNT) |
There was a problem hiding this comment.
Not that it matters much but shouldn't it be %d
There was a problem hiding this comment.
It could be, but I've never done it that way. Always worked with %s.
ssadler
changed the title
ssadler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1012
This is done so that transactions with large amounts can be safely constructed in Javascript.
To be merged with #1225