Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename validity to blocks_validity_status #1643

Merged

Conversation

ketanbhatt
Copy link
Contributor

Fixes #679

@codecov-io
Copy link

codecov-io commented Jul 9, 2017

Codecov Report

Merging #1643 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1643   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          59       59           
  Lines        2862     2862           
=======================================
  Hits         2818     2818           
  Misses         44       44

@ttmc ttmc requested a review from sbellem July 10, 2017 15:45
@ttmc
Copy link
Contributor

ttmc commented Jul 10, 2017

Hi @ketanbhatt

Before we can merge this pull request, we need you or your organization to agree to one of our contributor agreements. One of the big concerns for people using and developing open source software is that someone who contributed to the code might claim the code infringes on their copyright or patent. To guard against this, we ask all our contributors to sign a Contributor License Agreement. This gives us the right to use the code contributed and any patents the contribution relies on. It also gives us and our users comfort that they won't be sued for using open source software. We know it's a hassle, but it makes the project more reliable in the long run. Thank you for your understanding and your contribution!

If you are contributing on behalf of yourself (and not on behalf of your employer or another organization you are part of) then you should:

  1. Go to: https://www.bigchaindb.com/cla/
  2. Read the Individual Contributor Agreement
  3. Fill in the form "For Individuals"
  4. Check the box to agree
  5. Click the SEND button

If you're contributing as an employee, and/or you want all employees of your employing organization to be covered by our contributor agreement, then someone in your organization with the authority to enter agreements on behalf of all employees must do the following:

  1. Go to: https://www.bigchaindb.com/cla/
  2. Read the Entity Contributor Agreement
  3. Fill in the form "For Organizations”
  4. Check the box to agree
  5. Click the SEND button

We will email you (or your employer) with further instructions.

@ketanbhatt
Copy link
Contributor Author

@ttmc I have submitted the form

@ketanbhatt
Copy link
Contributor Author

This is to confirm that I agreed to and accepted the BigchainDB Individual Contributor Agreement at https://www.bigchaindb.com/cla/ and to represent and warrant that I have authority to do so.

pzd3CfnK62fosVwNj4Wkxbd57yPdAPvCrP1aY6fFI30pcpztB5Fcfvs8kySfKTw

@ttmc
Copy link
Contributor

ttmc commented Jul 10, 2017

Thanks @ketanbhatt ! That completes the CLA process.

I assigned @sbellem to review this PR because he created the original issue. He's at EuroPython this week, so he might not get around to reviewing it right away.

@ketanbhatt
Copy link
Contributor Author

@sbellem anything pending on my side?

@r-marques
Copy link
Contributor

Hi @ketanbhatt,

Sorry for the delay. @sbellem is on vacation.
The pr looks good to me. We should merge this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants