Problem: HTTP API docs wrong regarding the mode parameter #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Edit those docs to be accurate
ldmberman
reviewed
Aug 27, 2018
| `Tendermint broadcast API | ||
| <https://tendermint.com/docs/tendermint-core/using-tendermint.html#broadcast-api>`_. | ||
|
|
||
| The meaning of the ``mode`` query parameter is inhereted from the mode parameter in |
ldmberman
approved these changes
Aug 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #2481 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 41 41
Lines 2383 2383
=======================================
Hits 2169 2169
Misses 214 214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Edit those docs to be accurate
In particular, note that the BigchainDB node always does a check of transaction validity before ever sending it to Tendermint and before doing any HTTP response.
Thanks to @ldmberman who noticed this error.