Fix exception #32
Merged
Fix exception #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
sbellem
force-pushed
the
fix-exception
branch
from
8461d60
to
ee8dfb3
Compare
| monkeypatch.setattr(Processes, 'start', lambda *args: None) | ||
|
|
||
|
|
||
| @ pytest.fixture |
There was a problem hiding this comment.
Remove whitespace between @ and pytest.fixture
Besides the fact that explicit names are generally considered a better practice, one should also keep in mind that when debugging, a variable like "p" clashes with the debugger command.
sbellem
force-pushed
the
fix-exception
branch
from
9bdfc9b
to
9919e27
Compare
|
👍 and thanks for improving the coverage. |
vrde
added a commit
that referenced
this pull request
Feb 15, 2016
Fix exception when running `start`. Close #35
|
@vrde Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original goal of this PR was to resolve issue #35.
In addition to solving the above, tests were added for the
bigchaindbcommand.