Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New and revised timestamp docs #397

Merged
merged 7 commits into from Jun 24, 2016
Merged

New and revised timestamp docs #397

merged 7 commits into from Jun 24, 2016

Conversation

ttmc
Copy link
Contributor

@ttmc ttmc commented Jun 22, 2016

I revised the BigchainDB documentation on timestamps:

  • Added a new "Timestamps in BigchainDB" page in the Topic Guides.
  • Fixed the docstring for the timestamp() function. It gets the Unix time, not UTC. The two are related, but different. In particular, UTC has leap seconds but Unix time doesn't.
  • Made a suggestion on NTP daemon settings (if doing cluster node setup).
  • Revised the timestamp explanations in the page about data models (transactions, blocks, votes)

@codecov-io
Copy link

codecov-io commented Jun 22, 2016

Current coverage is 88.39%

Merging #397 into master will increase coverage by 0.08%

@@             master       #397   diff @@
==========================================
  Files            18         18          
  Lines          1266       1284    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1118       1135    +17   
- Misses          148        149     +1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by cc20136...82958ad


The result is that some timestamps can't be converted unambigously to a single UTC timestamp, but that only happens for leap seconds, and leap seconds are rare. (Only 26 had been inserted between 1972 and the end of 2015.)

**So long as you avoid the leap seconds, you can convert BigchainDB timestamps (Unix time timestamps) to UTC unambiguosly using any standard conversion tool or library function.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unambiguosly --> unambiguously

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that.

@sbellem
Copy link
Contributor

sbellem commented Jun 23, 2016

👍

@r-marques
Copy link
Contributor

👍

@ttmc
Copy link
Contributor Author

ttmc commented Jun 24, 2016

Please don't merge this yet. I still want to clarify how to do (BigchainDB timestamp) --> UTC conversion for leap seconds.

@ttmc ttmc merged commit 2b4c230 into master Jun 24, 2016
@ttmc ttmc mentioned this pull request Jul 15, 2016
5 tasks
@ttmc ttmc deleted the new-and-revised-timestamp-docs branch July 29, 2016 12:39
sbellem pushed a commit to sbellem/bigchaindb that referenced this pull request Oct 24, 2016
…estamp-docs

New and revised timestamp docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants