Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: make pip3 installation instructions consistent with Docker and AWS #481

Merged
merged 1 commit into from Jul 25, 2016

Conversation

ttmc
Copy link
Contributor

@ttmc ttmc commented Jul 25, 2016

The documentation's instructions for installing pip3 had become inconsistent with how we do it in the AWS deployment scripts and the Dockerfile. We now use sudo apt-get install python3-pip rather than:

sudo apt-get install python3-setuptools
sudo easy_install3 pip

@codecov-io
Copy link

codecov-io commented Jul 25, 2016

Current coverage is 90.91% (diff: 100%)

Merging #481 into master will not change coverage

@@             master       #481   diff @@
==========================================
  Files            18         18          
  Lines          1299       1299          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1181       1181          
  Misses          118        118          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 9683d3f...e17e36a

@vrde
Copy link
Contributor

vrde commented Jul 25, 2016

👍

minor note: if you are working on a virtual env based on Python3, then usually pip and pip3 are the same commands.

@ttmc
Copy link
Contributor Author

ttmc commented Jul 25, 2016

I think that's covered by this sentence: "In the following instructions, we call it pip3 but you may be able to use pip if that refers to the same thing."

I leave it up to them to determine if they refer to the same thing.

@ttmc ttmc merged commit 0098b5f into master Jul 25, 2016
@ttmc ttmc deleted the consistent-pip3-install-sequence branch August 17, 2016 18:17
sbellem pushed a commit to sbellem/bigchaindb that referenced this pull request Oct 24, 2016
…tall-sequence

Docs: make pip3 installation instructions consistent with Docker and AWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants