Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multiprocessing for vote #515

Merged
merged 11 commits into from
Aug 15, 2016
Merged

Conversation

vrde
Copy link
Contributor

@vrde vrde commented Aug 2, 2016

Closes #494, closes #43, closes #122

@codecov-io
Copy link

codecov-io commented Aug 2, 2016

Current coverage is 92.07% (diff: 84.21%)

Merging #515 into master will increase coverage by 0.17%

@@             master       #515   diff @@
==========================================
  Files            20         20          
  Lines          1210       1161    -49   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1112       1069    -43   
+ Misses           98         92     -6   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 0f86a8a...702fbe6

def initial():
"""Return unvoted blocks."""
b = Bigchain()
initial = b.get_unvoted_blocks()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confusing assigning a variable with the same name as the method

@r-marques
Copy link
Contributor

This pr is related to #510
After both are merged there will need to be some cleanup.
I guess bigchaindb/voter.py and tests/db/test_voter.py could be deleted

@r-marques r-marques self-assigned this Aug 9, 2016
@r-marques
Copy link
Contributor

👍

@vrde vrde merged commit 702fbe6 into master Aug 15, 2016
@vrde vrde deleted the refactor-multiprocessing-for-vote branch March 21, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants