get_transaction will now return a tx from backlog, even if there are some in invalid blocks #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttmc
changed the title
|
Note: I originally didn't add the second test and code coverage went down slightly. Once I added the second test, code coverage went up by 0.06%. |
sbellem
reviewed
Nov 8, 2016
| input_tx = b.get_transaction(input_tx.txid) | ||
| inputs = input_tx.to_inputs() | ||
| tx = Transaction.transfer(inputs, [user_vk], input_tx.asset) | ||
| tx = tx.sign([user_sk]) |
There was a problem hiding this comment.
Just a note, not a blocker to merge this PR.
I wonder whether it is really needed to write a "real" tx for this test, as it seems all we would need is a "dummy" tx, just to make sure the block in-validation can take place.
There was a problem hiding this comment.
Yeah, but I'm not sure how to go about that. I based the two "new" tests on the one original test, so at least this is no worse than before.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a slight change to how
Bigchain.get_transaction()works.Before, if there was a transaction with the specified
txidin the backlog and in some invalid blocks (but nowhere else),Bigchain.get_transaction()would returnNone. I changed it so that in that case, it returns the transaction from the backlog (and if the user asked for the transaction's status, it will be'backlog').I updated and expanded the docstring for
Bigchain.get_transaction().I also changed the test which checked to see the response to
Bigchain.get_transaction()when there's a copy of the transaction in an invalid block. Before, it didn't care about the backog: the response was always expected to beNone. Now it does care about the backlog, so the original test was split into two tests: