get_transaction_by_metadata_id now ignores invalid transactions #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.85% (diff: 100%)@@ master #811 diff @@
==========================================
Files 26 26
Lines 1682 1687 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1627 1634 +7
+ Misses 55 53 -2
Partials 0 0
|
diminator
reviewed
Nov 16, 2016
| txids = self.backend.get_txids_by_metadata_id(metadata_id) | ||
| transactions = [] | ||
| for txid in txids: | ||
| tx = self.get_transaction(txid) |
There was a problem hiding this comment.
maybe a small comment here that self.get_transaction returns None for invalid tx's
rhsimplex
approved these changes
Nov 17, 2016
added 4 commits
November 17, 2016 12:45
…-metadata-id-ignore-invalid-blocks
…-metadata-id-ignore-invalid-blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #792