New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the "api_endpoint" setting from everywhere (in this repo) #821
Conversation
@sbellem Could you try out the Dockerfile and Docker Compose file to see if that stuff is still okay? I did some testing but I'm not a Docker pro. I created a related issue to update the BigchainDB Python Driver (docs etc.): bigchaindb/bigchaindb-driver#142 |
Oh interesting, we have |
|
Just grepped through my local repos (which should include most of our docker-related files) and only found two instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some manual testing and I was able to run configure
, start
, and show-config
.
Current coverage is 96.64% (diff: 100%)@@ master #821 diff @@
==========================================
Files 27 27
Lines 1669 1669
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1613 1613
Misses 56 56
Partials 0 0
|
This pull request can probably be merged around the same time as bigchaindb/bigchaindb-driver#171 |
bigchaindb/bigchaindb-driver#171 was merged earlier today so I'm merging this pull request now. Farewell, "api_endpoint" |
As described in issue #780, the
api_endpoint
setting isn't actually used anywhere (as far as I can tell), so I removed it from everywhere.I added some docs to the page about the HTTP API to explain how the API Root URL is actually determined.
bigchaindb load
command seems to be broken now; that's another issue)Resolves #780