Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken & redirecting links in the docs #930

Merged
merged 11 commits into from Dec 12, 2016
Merged

Fixed broken & redirecting links in the docs #930

merged 11 commits into from Dec 12, 2016

Conversation

ttmc
Copy link
Contributor

@ttmc ttmc commented Dec 11, 2016

There were some broken and redirecting links in the root and server docs. I fixed them.

@codecov-io
Copy link

codecov-io commented Dec 11, 2016

Current coverage is 98.82% (diff: 100%)

Merging #930 into master will not change coverage

@@             master       #930   diff @@
==========================================
  Files            22         22          
  Lines          1361       1361          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1345       1345          
  Misses           16         16          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update efbc1e1...8c5947a

You need to have recent versions of [docker engine](https://docs.docker.com/engine/installation/#installation)
and [docker-compose](https://docs.docker.com/compose/install/).
You need to have recent versions of [Docker Engine](https://docs.docker.com/engine/installation/)
and (Docker) [Compose](https://docs.docker.com/compose/install/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the

(Docker) Compose

was intentional? Should it have been

Docker Compose

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the Docker folks are referring to it as just "Compose" and not as "Docker Compose" (in their documentation).

https://docs.docker.com/compose/install/

Of course, that only makes sense in the context of the Docker universe, hence the parenthetical "(Docker)" in front.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK. It looks like they're somewhat inconsistent with it, but it's probably to avoid repetition since they say things like

Install... Engine and Compose

Which sound less repetitive than saying

Install... Docker Engine and Docker Compose

LGTM 👍.

@ttmc ttmc merged commit 4493c17 into master Dec 12, 2016
@ttmc ttmc deleted the fix-links-in-docs branch January 3, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants