Merge pull request #193 from bigchaindb/fixing_forEach

changed forEach method
bigchaindb · Jun 6, 2018 · 2b665dc · 2b665dc
2 parents b62471a + 2021639
commit 2b665dc
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/transaction.js b/src/transaction.js
@@ -228,11 +228,12 @@ export default class Transaction {
      */
     static signTransaction(transaction, ...privateKeys) {
         const signedTx = clone(transaction)
+        const serializedTransaction =
+            Transaction.serializeTransactionIntoCanonicalString(transaction)
+
         signedTx.inputs.forEach((input, index) => {
             const privateKey = privateKeys[index]
             const privateKeyBuffer = Buffer.from(base58.decode(privateKey))
-            const serializedTransaction =
-                Transaction.serializeTransactionIntoCanonicalString(transaction)
 
             const transactionUniqueFulfillment = input.fulfills ? serializedTransaction
                 .concat(input.fulfills.transaction_id)
@@ -245,9 +246,9 @@ export default class Transaction {
             input.fulfillment = fulfillmentUri
         })
 
-        const serializedTransaction =
+        const serializedSignedTransaction =
             Transaction.serializeTransactionIntoCanonicalString(signedTx)
-        signedTx.id = sha256Hash(serializedTransaction)
+        signedTx.id = sha256Hash(serializedSignedTransaction)
         return signedTx
     }
 }