changed forEach method #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 84.43% 85.99% +1.55%
==========================================
Files 11 11
Lines 257 257
==========================================
+ Hits 217 221 +4
+ Misses 40 36 -4
Continue to review full report at Codecov.
|
future-is-present
suggested changes
Jun 5, 2018
src/transaction.js
Outdated
| @@ -245,9 +246,9 @@ export default class Transaction { | |||
| input.fulfillment = fulfillmentUri | |||
| }) | |||
|
|
|||
| const serializedTransaction = | |||
| const serializedSecondTransaction = | |||
There was a problem hiding this comment.
This is not a proper way of calling it as the transaction is the same. You could use serializedSignedTransaction instead or any other that represents better that constant
There was a problem hiding this comment.
Yes, I was thinking it was a bade naming just want to check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed for each and name of the second serializedTransaction