Problem: Test "Valid TRANSFER transaction with multiple Ed25519 inputs..." failing #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 85.99% 84.43% -1.56%
==========================================
Files 11 11
Lines 257 257
==========================================
- Hits 221 217 -4
- Misses 36 40 +4
Continue to review full report at Codecov.
|
|
@amed83 I added you as a reviewer. Can you check, test and merge if everything looks good for you? Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Resolving the promise inside the then() solves the issue.
The test is failing sometimes, specially when you change the asset or metadata object in constants. That is happening because you get invalid input as the
conn.postTransactionCommit(transferTxSigned2)is not completed and the input is not valid.