Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding async method #197

Merged
merged 3 commits into from
Jun 28, 2018
Merged

adding async method #197

merged 3 commits into from
Jun 28, 2018

Conversation

amed83
Copy link

@amed83 amed83 commented Jun 12, 2018

I've added async method, and changed postTransaction end-point to "transactionCommit"
Closes #191

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #197 into master will increase coverage by 1.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   84.43%   85.65%   +1.22%     
==========================================
  Files          11       11              
  Lines         257      258       +1     
==========================================
+ Hits          217      221       +4     
+ Misses         40       37       -3
Impacted Files Coverage Δ
src/connection.js 88.88% <0%> (-3.42%) ⬇️
src/baseRequest.js 79.31% <0%> (+6.89%) ⬆️
src/request.js 92.85% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206e4ce...d812e64. Read the comment docs.

@future-is-present
Copy link
Contributor

Good.
Please add docs and maybe some tests

Copy link
Contributor

@future-is-present future-is-present left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs need to be updated

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@206e4ce). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage          ?   86.82%           
=========================================
  Files             ?       11           
  Lines             ?      258           
  Branches          ?        0           
=========================================
  Hits              ?      224           
  Misses            ?       34           
  Partials          ?        0
Impacted Files Coverage Δ
src/connection.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206e4ce...9077d6c. Read the comment docs.

@future-is-present
Copy link
Contributor

@jernejpregelj can you review? :)

@future-is-present future-is-present merged commit 5c97769 into master Jun 28, 2018
@future-is-present future-is-present deleted the adding_asyncMethod branch June 28, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants