-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegated signature #304
Delegated signature #304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 95.16% 95.31% +0.15%
==========================================
Files 13 13
Lines 310 320 +10
==========================================
+ Hits 295 305 +10
Misses 15 15
Continue to review full report at Codecov.
|
Thank you @getlarge! Looks great! We need to come to conclusion on what to pass to the signing callback. I made lazy choice of passing the whole tx mapping. And you additionally pass input field. I'll make adjustments to python-driver pr and report back today. Any thoughts on what the interface supposed to be? |
Since inside the I also think it make sense to pass the whole the transaction if someone needs information to perform the signature, it will be available in the callback. I'd like to also make this function's interface working for partial signature of a transaction, but my brain is still stuck on understanding all the tenants. |
@zzappie So should we modify the |
I'm doubtful that there is a use case for passing the whole transaction.
It doesn't mean there is no such case.
But lets go through other tx fields.
"id": non existent at point of delegation
"version": Maybe we need it?
"outputs": Non existent at point of delegation
"operation": Doesn't matter
"asset" and "metadata: We already got message prepared
I think that if someone really will need something more than input to
know which private key to use for sighing. They could achieve it build
key selection logic that happens prior to delegation. So in my
opinion to keep clean interface we can go with just input and message.
WDYT?
|
Your summary makes sense. Do you know if When you mean |
Your summary makes sense. Do you know if `version` has an influence on
the type of signature to provide, or there were changes of the
expected signatures/fulfillement across versions of BigChain ?
I think information present in input should be enough for now. 2.0 spec
is going to be "the latest" for a while, and driver versioning is not
closely tied to spec versioning. So we have the room to adapt if we
find edge cases. And one of the design goals for this feature was to
keep exposure of driver an bigchaindb tx spec specific things to minimum
to the callback. I allready pushed updates to bigchaindb-driver.
When you mean `message`, you talk about the transaction hash right ?
Yep right.
One thing though. According to our CLA you need to sign-off the commits
You cand do so by running
git rebase --signoff HEAD~6
And then force push the branch. It will add
Signded-off by: Your Name <your@e.mail>
to commit messages.
An we'll be ready to merge!
|
Signed-off-by: getlarge <ed@getlarge.eu>
Signed-off-by: getlarge <ed@getlarge.eu>
Signed-off-by: getlarge <ed@getlarge.eu>
Signed-off-by: getlarge <ed@getlarge.eu>
Signed-off-by: getlarge <ed@getlarge.eu>
Signed-off-by: getlarge <ed@getlarge.eu>
ed7724b
to
3447022
Compare
Implement logic from @zzappie in Python driver.