This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Add ability to get ordered tx history of an entity #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
commented
Feb 9, 2017
| else: | ||
| raise | ||
| return reraises_if_not | ||
| return decorator | ||
|
|
||
|
|
||
| def order_transactions(transactions): |
There was a problem hiding this comment.
cc @libscott in case you were curious about the result of our conversation earlier about reconstructing a list of transaction's orders.
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 98.21% 98.78% +0.56%
==========================================
Files 3 3
Lines 56 82 +26
==========================================
+ Hits 55 81 +26
Misses 1 1
Continue to review full report at Codecov.
|
sohkai
force-pushed
the
support-history-queries
branch
from
75a8bb4
to
ae68436
Compare
Checking that there exists only one transaction that is not a input dependency for any other transaction makes the missing transaction and multiple non-fulfill checks redundant. Missing transaction: If there were a missing transaction, the transaction immediately preceding the missing transaction would be found to be an extra non-depended-upon transaction. Non-fulfill: Each transaction that isn't dependent on any other transaction creates a non-depended-upon transaction at their end. If there are multiple of these transactions, given that each transaction can only contain one input dependency, there would be multiple non-depended-upon transactions found in the list.
sohkai
force-pushed
the
support-history-queries
branch
from
ae68436
to
f14b34b
Compare
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements entity histories through the
api/v1/transactions?asset_idAPI.As the API may not necessarily return a correct chain of transactions, we post process the list given back to order them properly.