Skip to content

Commit

Permalink
Prevent heading from displaying when no price ranges are available (#…
Browse files Browse the repository at this point in the history
…1545)

* Prevent heading from displaying when no price ranges are available

It is possible for a category to have an insufficient number of items to generate price ranges. If the theme is customized to display the "Shop by Price" sidebar and the category does not generate a price range, only the heading is displayed.

* Add changelog for #1545

* Combine conditional for determining if price block displays

* Resolve conflict in changelog
  • Loading branch information
AlbertJBurton authored and bookernath committed Jul 23, 2019
1 parent eb04a8d commit 1c7ee65
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -11,6 +11,7 @@
- Fix incorrect DOM selectors causing the payment method form on the account page from working properly in Safari [#1541](https://github.com/bigcommerce/cornerstone/pull/1541)
- Add Amazon Pay and Google Pay to payment icons in footer [#1542](https://github.com/bigcommerce/cornerstone/pull/1542)
- Remove head.rsslinks [#1539](https://github.com/bigcommerce/cornerstone/pull/1539)
- Prevent heading from displaying when no price ranges are available [#1545](https://github.com/bigcommerce/cornerstone/pull/1545)

## 3.5.1 (2019-06-24)
- Fix conditional logic in share.html [#1522](https://github.com/bigcommerce/cornerstone/pull/1522)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/category/shop-by-price.html
@@ -1,4 +1,4 @@
{{#if theme_settings.shop_by_price_visibility}}
{{#and theme_settings.shop_by_price_visibility shop_by_price}}
<div class="sidebarBlock">
<h5 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h5>
<ul class="navList">
Expand All @@ -17,4 +17,4 @@ <h5 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h5>
{{/any}}
</ul>
</div>
{{/if}}
{{/and}}

0 comments on commit 1c7ee65

Please sign in to comment.