Prevent heading from displaying when no price ranges are available #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for a category to have an insufficient number of items to generate price ranges. If the theme is customized to display the "Shop by Price" sidebar and the category does not generate a price range, only the heading is displayed.
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
reviewed
Jul 19, 2019
|
This looks good, can you rebase to resolve the conflict with CHANGELOG.md? Thanks again for your contribution. |
bookernath
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It is possible for a category to have an insufficient number of items to generate price ranges. If the theme is customized to display the "Shop by Price" sidebar and the category does not generate a price range, only the heading is displayed. This change ensures there are price ranges available before displaying the heading and price ranges.
Tickets / Documentation
N/A
Screenshots (if appropriate)
Example of heading displayed with no price ranges.