Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-4391 - Migrate jQuery from 2->3 #1162

Merged
merged 1 commit into from
Feb 21, 2018
Merged

STRF-4391 - Migrate jQuery from 2->3 #1162

merged 1 commit into from
Feb 21, 2018

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Feb 2, 2018

What?

NOTES

Ticket

ping @bigcommerce/storefront-team

@bigbot
Copy link

bigbot commented Feb 2, 2018

Autotagging @bigcommerce/storefront-team @davidchin

package.json Outdated
@@ -6,14 +6,15 @@
"author": "BigCommerce",
"license": "MIT",
"dependencies": {
"@bigcommerce/stencil-utils": "^1.0.10",
"@bigcommerce/stencil-utils": "github:mjschock/stencil-utils#STRF-4391",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: swap with latest version after merging bigcommerce/stencil-utils#78

@mjschock
Copy link
Contributor Author

@davidchin - i'm wondering if you see any issues with this update?

Copy link
Contributor

@Ubersmake Ubersmake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚. Full UI and Stencil groups have been run. Failing tests have been re-run and verified as passing. Failures in ThemeEditorProductPageProductReviewsUITest and ThemeEditorProductPageRelatedProductsUITest are test issues that need to be addressed in https://jira.bigcommerce.com/browse/STRF-4507.

@mjschock mjschock merged commit 27e31d1 into bigcommerce:master Feb 21, 2018
@mjschock mjschock deleted the STRF-4391 branch February 21, 2018 19:00
mjschock added a commit that referenced this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants