Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize faceted search item's title #1426

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Sanitize faceted search item's title #1426

merged 2 commits into from
Apr 10, 2019

Conversation

A-Jarrell
Copy link
Contributor

@A-Jarrell A-Jarrell commented Jan 21, 2019

What?

This pull request uses the handlebars helper {{ sanitize }} to remove HTML tags from facets' titles on category pages.

Tickets / Documentation

@bigbot
Copy link

bigbot commented Jan 21, 2019

Autotagging @bigcommerce/storefront-team @davidchin

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please add a changelog entry.

@A-Jarrell
Copy link
Contributor Author

@junedkazi Changelog entry added.

@sandeepgraju
Copy link
Contributor

merging , change log entry no longer requirement going fwd

@junedkazi junedkazi dismissed their stale review April 9, 2019 22:23

changelog is not required

@Ubersmake
Copy link
Contributor

Thank you for this @A-Jarrell .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants