Sanitize faceted search item's title #1426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
previously requested changes
Jan 31, 2019
Contributor
junedkazi
left a comment
junedkazi
left a comment
There was a problem hiding this comment.
LGTM. Can you please add a changelog entry.
Contributor
Author
|
@junedkazi Changelog entry added. |
Contributor
|
merging , change log entry no longer requirement going fwd |
Contributor
|
Thank you for this @A-Jarrell . |
This was referenced Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request uses the handlebars helper {{ sanitize }} to remove HTML tags from facets' titles on category pages.
Tickets / Documentation