Add option to display custom fields under "Additional Information" tab on PDP #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
reviewed
Apr 21, 2019
| @@ -1285,6 +1285,20 @@ | |||
| "force_reload": true, | |||
| "id": "show_product_details_tabs" | |||
| }, | |||
| { | |||
junedkazi
suggested changes
Apr 21, 2019
| @@ -7,6 +7,11 @@ | |||
| <a class="tab-title" href="#tab-warranty">{{lang 'products.warranty'}}</a> | |||
| </li> | |||
| {{/if}} | |||
| {{#all product.custom_fields theme_settings.show_custom_fields_tabs}} | |||
| <li class="tab"> | |||
| <a class="tab-title" href="#tab-specs">{{theme_settings.pdp-custom-fields-tab-label}}</a> | |||
There was a problem hiding this comment.
Can we build the href based on the label so it matches what we are actually calling the tab.
| @@ -22,6 +27,16 @@ | |||
| {{{product.warranty}}} | |||
| </div> | |||
| {{/if}} | |||
| {{#all product.custom_fields theme_settings.show_custom_fields_tabs}} | |||
| <div class="tab-content" id="tab-specs"> | |||
There was a problem hiding this comment.
Can we build the href based on the label so it matches what we are actually calling the tab.
|
@junedkazi Ran the string through |
junedkazi
approved these changes
Apr 22, 2019
config.json
Outdated
| @@ -304,6 +305,7 @@ | |||
| "pdp-sale-price-label": "Now:", | |||
| "pdp-non-sale-price-label": "Was:", | |||
| "pdp-retail-price-label": "MSRP:", | |||
| "pdp-custom-fields-tab-label": "Specifications", | |||
There was a problem hiding this comment.
Can we also change the label to be more generic like "Additional Information" ? 🍹
sacr3dc0w
changed the title
junedkazi
approved these changes
Apr 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds an option to display custom fields under a "Additional Information" tab.
Tickets / Documentation
Screenshots (if appropriate)
False, default
False, default - tab region
True
True, tab region - closed
True, tab region - open
True, tab region - open, mobile
True, tab region - closed
