Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display custom fields under "Specifications" tab on PDP #1295

Closed
wants to merge 1 commit into from
Closed

Conversation

sacr3dc0w
Copy link
Contributor

What?

Adds an option to display custom fields under a "Specifications" tab.

Tickets / Documentation

Screenshots (if appropriate)

False, default
01 false default

False, default - tab region
02 false tab region

True
03 true

True, tab region - closed
04 true tab closed

True, tab region - open
05 true tab open

True, tab region - open, mobile
true mobile

True, tab region - closed
06 theme editor

@bigbot
Copy link

bigbot commented Jun 29, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@sacr3dc0w
Copy link
Contributor Author

sacr3dc0w commented Jun 30, 2018

I've updated the PR and added the ability to change the tab label in the theme editor if the store owner doesn't want it to be "Specifications".

If this adds too much overhead, I can move it back to being a string in en.json.

Screenshot

True, modified label
screen shot 2018-06-29 at 7 45 32 pm

@sacr3dc0w
Copy link
Contributor Author

sacr3dc0w commented Jul 12, 2018

Upon rebasing and enabling show_product_reviews_tabs from #1302, I discovered this will create display issues if a product contains warranty information.

Required adding breakpoint("large") for .tab-title and slightly reducing the side padding of the tabs for this viewport.

Before
1 before

After
2 after

Updated theme editor
ezgif com-gif-maker

{
"type": "text",
"label": "Product custom fields tab label",
"force_reload": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this setting isn't relevant if the above setting isn't checked, we should add

"reference": "show_custom_fields_tabs",
"reference_default": false,

This will cause this setting to be invisible if the above checkbox is not checked

@ghost
Copy link

ghost commented Oct 9, 2018

@sacr3dc0w A new tab is a great idea and we would like to merge this pr, however, we would like to share the naming with our design team to get their approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants