STRF-7487 fix registerValidation function to always validate on writeReview-form email field #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-williamkwon
force-pushed
the
fixProductReviews
branch
from
1f6e27d
to
6cd4925
Compare
bc-williamkwon
changed the title
junedkazi
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There was an issue that was affecting Klaviyo in regards to product reviews as they were loading a third party script and the validator was validating against the third party script's email input field instead of the email input field that belonged to the writeReview-form css class. This pr is to fix that issue so that a third party script can be on the page and a user can still post a review.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.