Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRF-7487 fix registerValidation function to always validate on writeReview-form email field #1585

Merged
merged 1 commit into from
Oct 14, 2019
Merged

STRF-7487 fix registerValidation function to always validate on writeReview-form email field #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Draft
- Added missing gift certificate translation
- Fix registerValidation function to validate on writeReview-form email field [#1585](https://github.com/bigcommerce/cornerstone/pull/1585)

## 4.2.0 (2019-10-02)
- Fixes and some additions to our Google Structured Data schema for the product page template [#1577](https://github.com/bigcommerce/cornerstone/pull/1577)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/product/reviews.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default class {
validate: 'presence',
errorMessage: this.context.reviewComment,
}, {
selector: '[name="email"]',
selector: '.writeReview-form [name="email"]',
validate: (cb, val) => {
const result = forms.email(val);
cb(result);
Expand Down