Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYMENTS-5111 Proper address formatting without any additional commas… #1626

Merged
merged 1 commit into from
Jan 30, 2020
Merged

PAYMENTS-5111 Proper address formatting without any additional commas… #1626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Draft
- Add translation key for "read more" blog post link [#1625](https://github.com/bigcommerce/cornerstone/pull/1625)
- Update My Account Payment Methods template to expose all new savable payment methods [1603](https://github.com/bigcommerce/cornerstone/pull/1603)

- Proper address formatting without any additional commas in My Account Payment Methods [1626](https://github.com/bigcommerce/cornerstone/pull/1626)

## 4.3.1 (2020-01-17)
- Resolve visual regression in error modal icon animation [#1619](https://github.com/bigcommerce/cornerstone/pull/1619)
Expand Down
8 changes: 7 additions & 1 deletion templates/components/account/payment-methods-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@ <h4 class="paymentMethodsTitle">
{{!-- If there is an address STARTS --}}
<p class="methodDetails">
<span class="methodDetails-label">{{lang 'account.payment_methods.billing_address'}}:</span>
<span class="methodDetails-description">{{billing_address.address1}}, {{billing_address.address2}}, {{billing_address.city}}, {{billing_address.state}}, {{billing_address.zip}}, {{billing_address.country}}</span>
<span class="methodDetails-description">
<span>{{billing_address.address1}}, </span>
{{#if billing_address.address2}}
<span>{{billing_address.address2}}, </span>
{{/if}}
<span>{{billing_address.city}}, {{billing_address.state}} {{billing_address.zip}} {{billing_address.country}}</span>
</span>
</p>
{{!-- If there is an address ENDS --}}

Expand Down