fix(bctheme): BCTHEME-36 Product List Options Do Not Have a Max Height #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
golcinho
reviewed
Jul 1, 2020
junedkazi
approved these changes
Jul 1, 2020
| @@ -372,6 +372,8 @@ | |||
| border: $productOptions-list-border; | |||
| list-style: none; | |||
| margin: 0; | |||
| max-height: 400px; | |||
There was a problem hiding this comment.
How does this look on mobile or tablets. Can we confirm before we merge this one.
junedkazi
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
On Stencil themes, product list options do not have a set max height. This affects merchants that add a large amount of items to their product list options as it increases the length of the product page and pushes the add to cart button far down the page.
Tickets / Documentation
https://jira.bigcommerce.com/browse/BCTHEME-36
Screenshots (if appropriate)
ping @yurytut1993 @junedkazi