Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bctheme): BCTHEME-36 Product List Options Do Not Have a Max Height #1707

Merged
merged 2 commits into from
Jul 6, 2020
Merged

fix(bctheme): BCTHEME-36 Product List Options Do Not Have a Max Height #1707

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f860d97
fix(bctheme): BCTHEME-36 Product List Options Do Not Have a Max Height
BC-tymurbiedukhin Jul 1, 2020
c609ca9
Changed overflow-y value from scroll to auto
BC-tymurbiedukhin Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions assets/scss/components/stencil/productView/_productView.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,8 @@
border: $productOptions-list-border;
list-style: none;
margin: 0;
max-height: 400px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look on mobile or tablets. Can we confirm before we merge this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2020-07-06 at 11 33 01

Screenshot 2020-07-06 at 11 33 22

overflow-y: scroll;
BC-tymurbiedukhin marked this conversation as resolved.
Show resolved Hide resolved
}

.productOptions-list-item {
Expand Down